jobplanet code review strategy

Copyright All Rights Reserved © Jobplanet 2015

v.1.0�� 2015.01.04��

!Hosang�� Jeon��

[email protected]

Jobplanet Code Review Strategy

mailto:[email protected]


Why�� is�� code�� review�� necessary�� /�� so�� important?

• Improve coding skills. !• Discover and remove duplicated helpers, scripts etc. !

• Maintain uniform coding conventions (naming conventions for variable, methods etc.)

!• Understand what other people are doing. !

• Assurance that others can cover for you while on vacation.


Another�� benefit�� of�� code�� review

without code

review

Found a bugwith code review

Who did this!!!!

Oops. Did I miss something while reviewing the codes?

Bugs are NOT the fault of a single programmer. A good code review culture can detect and resolve problems early.


Code�� Review�� Strategy

No pain, No Gain

No thumbs-up, No Merge


Code�� Review�� Strategy

Need a “thumbs-up” from at least one of 3 people. Especially for new features / critical code paths.


While�� doing�� code�� review…⋯

• Share “easy to make mistakes” during code reviews.

• Share “good” code during code reviews.

• Share good discussions during code reviews.

• “Code review example” can be used during candidate screenings !

• Make “good/not-good code note” for new team members.


감사합니다.

jobplanet code review strategy

Software

rights reserved jobplanet