code review kata with gerrit
DESCRIPTION
Here are the slides of the code review kata given by Manuel at Open World Forum 2013. The exercice of code review is a key element to improve quality, to enable team members understanding and to share knowledge. Complementary to the pair-programming promoted by XP, code review is usually the unique case for distributed teams to make a real collaborative work on code. Gerrit is a tool for code review, based on Git. It comes from the Android project but, now, it is widely adopted by other free software communities (LibreOffice, Mediawiki, Eclipse, ...) as well as by large companies (Sony Mobile, Ericsson, SAP, Google, ...). In this session, we propose to understand how a good tool is essential for code review and how the couple GIT/Gerrit enables development teams to improve the quality of code.TRANSCRIPT
![Page 1: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/1.jpg)
CODE REVIEW KATA WITHGERRIT
/
© Enalean, 2013
This work is licensed under a .
Manuel Vacelet @vaceletm
Creative Commons Attribution-ShareAlike 3.0 Unported License
![Page 2: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/2.jpg)
BIO / CONTEXTEnalean CTO & developerTuleap
![Page 3: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/3.jpg)
WHY TO REVIEW CODE?
![Page 4: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/4.jpg)
WHERE IT COMES FROM?Well known practice in FLOSS worldVarious strategy: patches (LKML), "pull requests", ...
![Page 5: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/5.jpg)
GERRIT
Comes from Android projectGit onlyusers: Eclipse, QT, Mediawiki, Sony, Motorola, Google,SAP, ...
http://code.google.com/p/gerrit/
![Page 6: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/6.jpg)
GERRIT WORKFLOW
![Page 7: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/7.jpg)
REVIEWS DASHBOARD
![Page 8: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/8.jpg)
ONE REVIEW
![Page 9: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/9.jpg)
![Page 10: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/10.jpg)
PATCH
![Page 11: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/11.jpg)
![Page 12: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/12.jpg)
DIFF, COMMENTS
![Page 13: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/13.jpg)
![Page 14: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/14.jpg)
PUSH FOR REVIEWOne commit == One reviewShape your commits (history rewriting!)
git push ssh://[email protected]:29418 HEAD:refs/for/master
![Page 15: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/15.jpg)
COMMITS: SIZE MATTERSBeware The Big OneDifficult to grasp itTiny not better whatsoever
![Page 16: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/16.jpg)
SHAPE YOUR COMMITS!
![Page 17: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/17.jpg)
GOOD PRACTICESReduce the wait listDefine review rulesDamn fast Continuous Integration
![Page 18: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/18.jpg)
ACCESS CONTROL
![Page 19: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/19.jpg)
![Page 20: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/20.jpg)
CONCLUSIONPowerfulHigh learning curve@Enalean: highest dev ROI this year
![Page 21: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/21.jpg)
QUESTIONS?
![Page 22: Code Review Kata with Gerrit](https://reader034.vdocuments.mx/reader034/viewer/2022050816/54b70aaf4a79596c528b45dd/html5/thumbnails/22.jpg)
CREDITSIt's all about feedback - code review as a great tool in theagile toolboxScaling Up JGitDeploying Gerrit Code Review